Merged
Conversation
Member
|
Awesome, this looks huge. I'll let you merge this directly, since I don't think I'll have the time to crunch through 6k lines of code any time soon. I hope you've started your semester well, and I'm looking forward to when you're back :) |
arthurkehrwald
force-pushed
the
feature/media-controller
branch
from
151b507 to
32f4f6a
Compare
…troller Spent two hours trying to rebase again. Tired of it.
Contributor
Author
|
I tried for two hours to rebase this. Didn't work. Possibly because this PR contains commits that I originally made to a different repo. @freezy, can you just merge it? I think the settings don't allow me to do it. |
Member
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a BCP interface and some rudimentary media controller functionality. The BCP protocol is implemented up to specification. All documented BCP commands can be sent, received, and parsed into and from strongly typed objects. BCP has some undocumented features (e.g. slides) that are not supported. The media controller built on top of this foundation is very bare-bones. It can currently only play sounds when events and modes are triggered and display player and machine variables from MPF.
I am starting the first semester of my master's program tomorrow, so this will probably be my last major contribution for a while.